Skip to content

Document how to write python-lsp-server plugin + add pylsp-rope to Readme #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

lieryan
Copy link
Contributor

@lieryan lieryan commented Oct 3, 2021

Currently, writing a plugin for python-lsp-server is rather difficult, there is very little documentation on how to do this other than just a short pointer to "see [existing plugins] for examples on how to write plugins".

There's quite a number of non-obvious knowledge that one has to know, which is quite an impediment for people wanting to write plugins. I wanted to change that, so I've written a cookiecutter template that aims to make it much easier to start a pylsp plugin project and also aims to document how to write plugins in more depth.

Ideally, I think python-lsp-server documentation should be owned by python-lsp's organisation rather than in my own repository, so I'd request if python-lsp-server core maintainers are interested in this project, to help adopt the project into the python-lsp Github Organisation, so it can be maintained by the community rather than as an external project on my user's namespace.

The primary test case for this template is pylsp-rope, which is the first pylsp plugin written to use the template and the main driver for me wanting to write a python-lsp-server plugin. Also, this just happens to be the first public announcement of pylsp-rope, so I'm also quite excited to announce that now you can use Rope from an LSP, beyond the basic renaming and completion that exists in the current built-in Rope support.

@ccordoba12
Copy link
Member

ccordoba12 commented Oct 3, 2021

Ideally, I think python-lsp-server documentation should be owned by python-lsp's organisation rather than in my own repository, so I'd request if python-lsp-server core maintainers are interested in this project, to help adopt the project into the python-lsp Github Organisation, so it can be maintained by the community rather than as an external project on my user's namespace.

I agree with this and thanks a lot for your help and interest in our project. I'll create a repo for that cookiecutter and add you as admin so you can move it to our organization.

Also, this just happens to be the first public announcement of pylsp-rope, so I'm also quite excited to announce that now you can use Rope from an LSP, beyond the basic renaming and completion that exists in the current built-in Rope support.

Nice! Good luck with that project. Perhaps we could use it in Spyder in the future.

@lieryan
Copy link
Contributor Author

lieryan commented Oct 4, 2021

Thanks for the invite @ccordoba12, I've migrated the cookiecutter/doc project over to python-lsp and updated the pull request accordingly.

Perhaps we could use it in Spyder in the future.

Once the project matures a bit. That would be lovely!

@ccordoba12 ccordoba12 modified the milestones: v1.3.0, v1.2.3 Oct 4, 2021
@ccordoba12 ccordoba12 changed the title Document how to write python-lsp-server plugin + add pylsp-rope Document how to write python-lsp-server plugin + add pylsp-rope to Readme Oct 4, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lieryan!

@ccordoba12 ccordoba12 merged commit b63abc3 into python-lsp:develop Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants